fix toolbar stickness issue

[Shulammite-Aso]

fixes #394
Toolbar now only floats when the scroll is on the editor text/body area, in both Rich and Markdown mode.

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt jasmine
• code is in uniquely-named feature branch and has no merge conflicts
• PR is descriptively titled
• PR body includes fixes #0000-style reference to original issue #
• ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

[Shulammite-Aso]

@jywarren @emilyashley @Shreyaa-s @keshav234156 @NitinBhasneria

i think i may need to also make the toolbar responsive on this PR, or do we need to open a different PR for that?

[Shulammite-Aso]

@emilyashley @jywarren @keshav234156 @NitinBhasneria @Shreyaa-s please review.

[NitinBhasneria]

Great work @Shulammite-Aso.
I just want to add that the toolbar sickness is not consistent as it is to be. When we scroll up the toolbar disappears and appears again(on further scrolling).
Expected Behaviour: The toolbar should stick when we scroll up(it should not disappear and appear) and it should disappear when toolbar comes to the top of the editor.

[Shulammite-Aso]

Thanks @NitinBhasneria
I was seeing similar behaviour until i added my last commit, i think it fixed it as i no longer see it, i don't know why can still observe it. Did you pull in my last commit? or maybe you should try reloading your browser.

[NitinBhasneria]

Thanks @NitinBhasneria
I was seeing similar behaviour until i added my last commit, i think it fixed it as i no longer see it, i don't know why can still observe it. Did you pull in my last commit? or maybe you should try reloading your browser.

Can you attach the gif of changes after the last commit?

[Shulammite-Aso]

Okay @NitinBhasneria i think i understand what you mean better now, the toolbar isn't beginning to float immediately it hits the footer.. I'll try to fix that.

[Shulammite-Aso]

Hi @NitinBhasneria this works fine now i guess, do check.

[emilyashley]

Awesome, thanks for this! I think it's fine to have it in two different PR's :)

[NitinBhasneria]

Awesome @Shulammite-Aso.

[shreyaa-s-zz]

This looks good. Great work @Shulammite-Aso ! 😄

[Shulammite-Aso]

@jywarren i think we can merge this, as it does solve the basic problem, which is making the toolbar accessible while not having it float outside the text area. Other design options will be a matter of preference. We can change it to suit other popular preference if there becomes need for it.

Thanks!!!

[jywarren]

This is awesome. Thanks for all the reviews and refinements. I'll merge it now!

[Sagarpreet]

The logic is so simple and clean 😄