Export ordering fix #322
Merged
Export ordering fix #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Published to |
|
@jywarren I am updating our release draft just because its still a good way to keep track of updates and credit people. I was wondering if this was a bug fix? Why do we want to export the images in reverse order? |
|
Ah it was just that the exporter API wanted it bottom first, not top first as we'd sent it. So, just a mismatch in API convention, not an actual order change! Thanks! And we can publish a release if you want, this was a lot of changes! |
|
@jywarren just submitted the release summaries up to 0.6.1 - https://github.com/publiclab/Leaflet.DistortableImage/releases/tag/v0.6.1 |
|
Awesome!!!
…On Tue, Jul 9, 2019 at 4:54 PM Sasha Boginsky ***@***.***> wrote:
@jywarren <https://github.com/jywarren> just submitted the release
summaries up to 0.6.1 -
https://github.com/publiclab/Leaflet.DistortableImage/releases/tag/v0.6.1
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#322?email_source=notifications&email_token=AAAF6JYFHPVSXXEZRAICU4LP6T3EZA5CNFSM4H5JDW32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZRPWSI#issuecomment-509803337>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAF6J5L6GPHWNMTOE6Z2OLP6T3EZANCNFSM4H5JDW3Q>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes as follow-up to #316 #318