CSS selectors without class or id in v0.6.0

[flopail]

Describe the bug:
In leaflet.distortableimage.css, several CSS selectors include only HTML tags and no cleaner selectors such as class or id. As a result, these styles sometimes override other CSS styles you have in your app or website.

Reproduce the behavior:
Have a look to leaflet.distortableimage.css in dist folder, especially these CSS selectors:

• svg
• td
• th
• kbd

Browser, version, and operating system:

• Browsers : Firefox 67, Chrome 75
• Leaflet DistortableImage v0.6.0
• Operating system: Windows 10

[jywarren]

Oh gosh, thanks for this catch! We'll issue a patch promptly. You don't have one already created, do you? Just asking in case! Thanks again.

…

On Mon, Jul 8, 2019 at 9:42 AM flopail ***@***.***> wrote: *Describe the bug:* In leaflet.distortableimage.css, several CSS selectors include only HTML tags and no cleaner selectors such as class or id. As a result, these styles sometimes override other CSS styles you have in your app or website. *Reproduce the behavior:* Have a look to leaflet.distortableimage.css in dist folder, especially these CSS selectors: - svg - td - th - kbd *Browser, version, and operating system:* - Browsers : Firefox 67, Chrome 75 - Leaflet DistortableImage v0.6.0 - Platform: Windows 10 — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#330?email_source=notifications&email_token=AAAF6J3AUOK73D6NGQS5ADLP6M73NA5CNFSM4H6322RKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G53MIMQ>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAF6JYTT54IXESCK3G2EJTP6M73NANCNFSM4H6322RA> .

[flopail]

Hi @jywarren, no patch created on my side. Thanks!

[jywarren]

I /think/ this will work, although I want to double check with @sashadev-sky that the existing styles are preserved. You can point at that branch in the meantime if it's urgent, but I think we can get this resolved in a few hours. Thanks again!

#331

[sashadev-sky]

was svg overriding anything? I was thinking if we're mostly using svg for icons, then we should globally set it to 18px. Then in an instance where we don't want something to be 18px, we add more specific styling. Is this ok or do we not like this? I can add a comment above it in the css file explaining that?

[jywarren]

Ah well if this library is used in conjunction with any other code that has an svg, the style would be applied to everything. We'd best namespace our styles to avoid this! It's like using a global variable. Make sense?

…

On Mon, Jul 8, 2019, 8:16 PM Sasha Boginsky ***@***.***> wrote: was svg overriding anything? I was thinking if we're mostly using svg for icons, then we should globally set it to 18px. Then in an instance where we don't want something to be 18px, we add more specific styling. Is this ok or do we not like this? I can add a comment above it in the css file explaining that? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#330?email_source=notifications&email_token=AAAF6J7TZZRLLDPX7NSLO23P6PKE5A5CNFSM4H6322RKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZOWWAI#issuecomment-509438721>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAF6J5XY4U66CQJSBTYK53P6PKE5ANCNFSM4H6322RA> .

[sashadev-sky]

@flopail all fixed :) thank you for reporting this!