-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make locked images selectable #321
Comments
@sashadev-sky if you're able to help untangle this one, that'd be awesome! |
@jywarren ok let me try to make an "unlock all" action! Doing this now |
"unlock selected group"*** |
Ah, if it's possible, maybe preferable to leave them locked (even though
selected), as we may want to export even without deciding to unlock, so we
don't accidentally move them? Is that possible? Thanks!!!!
…On Wed, Jul 3, 2019 at 5:17 PM Sasha Boginsky ***@***.***> wrote:
"unlock selected group"***
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#321?email_source=notifications&email_token=AAAF6J27QPFDVJDU7J5F6L3P5UJMDA5CNFSM4H5HYX62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZFWNZY#issuecomment-508258023>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAF6J4MK2DJW7B3PZNQIPTP5UJMDANCNFSM4H5HYX6Q>
.
|
@jywarren yes I think I have implemented what you were requesting in #324! They can now be selected and exported while locked. In doing that I also added a sensible way to dealing with locking and unlocking groups. I think to make things the most clear, we should do similar to what I did for multi-delete and a message "you are exporting x num of images". |
This is important because for multiple image select, many images may be locked even as you're looking to export them. Let's make this change, and think through next steps:
If the lock icons still show, we should be OK, although perhaps we want to make groups unlockable.
But if the lock handle icons (
X
s) /don't/ show, we may need to add that (not in the initial fix but in follow-up) so that it's clear why you can't drag the images together. That should resolve any ambiguities!The text was updated successfully, but these errors were encountered: