Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make locked images selectable #321

Closed
jywarren opened this issue Jul 3, 2019 · 5 comments · Fixed by #324
Closed

Make locked images selectable #321

jywarren opened this issue Jul 3, 2019 · 5 comments · Fixed by #324

Comments

@jywarren
Copy link
Member

jywarren commented Jul 3, 2019

This is important because for multiple image select, many images may be locked even as you're looking to export them. Let's make this change, and think through next steps:

If the lock icons still show, we should be OK, although perhaps we want to make groups unlockable.

But if the lock handle icons (Xs) /don't/ show, we may need to add that (not in the initial fix but in follow-up) so that it's clear why you can't drag the images together. That should resolve any ambiguities!

@jywarren
Copy link
Member Author

jywarren commented Jul 3, 2019

@sashadev-sky if you're able to help untangle this one, that'd be awesome!

@sashadev-sky
Copy link
Member

@jywarren ok let me try to make an "unlock all" action! Doing this now

@sashadev-sky
Copy link
Member

"unlock selected group"***

@jywarren
Copy link
Member Author

jywarren commented Jul 3, 2019 via email

@sashadev-sky sashadev-sky mentioned this issue Jul 3, 2019
10 tasks
@sashadev-sky
Copy link
Member

@jywarren yes I think I have implemented what you were requesting in #324! They can now be selected and exported while locked. In doing that I also added a sensible way to dealing with locking and unlocking groups. I think to make things the most clear, we should do similar to what I did for multi-delete and a message "you are exporting x num of images".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants