Skip to content

Commit

Permalink
No need to link to nlohmann_json -- header only
Browse files Browse the repository at this point in the history
In using the system's nlohmann json library I ran into compilation errors that the library could not be linked to since `-lnlohmann` could not be found

I believe that nlohmann_json is a header only so it should be fine to remove this in all cases.
  • Loading branch information
hmaarrfk authored Nov 30, 2024
1 parent 0b6b9b6 commit 1d96544
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions external/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,6 @@ if(HELLOIMGUI_HAS_OPENGL AND NOT IMGUI_BUNDLE_DISABLE_IMMVISION)
set(IMMVISION_SERIALIZE_JSON ON CACHE INTERNAL "" FORCE)
add_subdirectory(immvision)
if (IMGUI_BUNDLE_WITH_IMMVISION)
target_link_libraries(immvision PUBLIC nlohmann_json)

target_link_libraries(imgui_bundle INTERFACE immvision)
hello_imgui_msvc_target_group_sources(immvision)
target_compile_definitions(imgui_bundle INTERFACE IMGUI_BUNDLE_WITH_IMMVISION)
Expand Down

0 comments on commit 1d96544

Please sign in to comment.