Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix IsRegularFile and LoadAssetFileData_Impl #59

Merged
merged 1 commit into from
Jun 4, 2023
Merged

fix IsRegularFile and LoadAssetFileData_Impl #59

merged 1 commit into from
Jun 4, 2023

Conversation

XMNXofficial
Copy link
Contributor

@XMNXofficial XMNXofficial commented Jun 3, 2023

Pull Request

Description

Can't load files which its name is encode by gbk

Change Type

  • Bug fix
  • Code refactoring

System Information

  • Operating System: Windows 11 (US Version)
  • System Architecture: 64-bit
  • Compiler: MinGW-w64

What Happened?

The function fopen and std::ifstream can't work if the file name has Chinese word and Japanese word.(Debug:they will return NULL)

Bug reproduction

The Test ssource: TestSrc_For_Window.zip

beforeFix
afterFix

@pthom
Copy link
Owner

pthom commented Jun 4, 2023

Well done, thanks!

@pthom pthom merged commit 65a2314 into pthom:master Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants