Unify -o long option to be --store-dir #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes make_studyvisit_archive to use -o / --store-dir, consistent with the other three scripts. The --output-dir argument is marked as deprecated but remains supported for the time being. Use of both long forms is guarded againist by using a mutually exclusive group. A deprecation warning is issued when --output-dir is used. When the deprecated parameter is removed, both the group and the warning can be done away with. As a side note, it seems that Python 3.13 will add "deprecated" to argparse's add_argument: https://docs.python.org/3.13/library/argparse.html#deprecated
adswa
reviewed
Aug 19, 2024
adswa
reviewed
Aug 19, 2024
Co-authored-by: Adina Wagner <adina.wagner@t-online.de>
|
I take the discussion above as an approval. The change does not break backwards compatibility, so I'm merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes
make_studyvisit_archiveto use-o / --store-dir, consistent with the other three scripts. The--output-dirargument is marked as deprecated but remains supported for the time being. Closes #52Use of both long forms is guarded againist by using a mutually exclusive group. A deprecation warning is issued when --output-dir is used. When the deprecated parameter is removed, both the group and the warning can be done away with.
As a side note, it seems that Python 3.13 will add "deprecated" to argparse's add_argument:
https://docs.python.org/3.13/library/argparse.html#deprecated