'See all holds' button for Ill requests #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l results 'See all __' button to say 'See all holds'.
banukutlu
approved these changes
Apr 3, 2023
banukutlu
pushed a commit
that referenced
this pull request
Apr 7, 2023
…lay (#546) * Update webpacker and .ruby-version * No Recalls: Landing page for no recalls hold placement and placing hold via ILLiad API * No Recalls: Adds volumetrics support and results page * Adds test config for illiad * Adds notes support and ebook field * Place_hold_date_component refactor * Updates controller specs after place loan results display refactor * Adds SYMWS_EDIT_OVERRIDE to docker-compose setup Co-authored-by: Banu Kutlu <bzk60@psu.edu> * Illiad Holds and Checkouts (#557) * Rebase updates, fix yarn.lock, accessibility and ill result specs fixes * Changes ILL Hold Defaults(#603) Unchecks accept_alternate_edition and accept_ebook by default for ILL holds. Sets default not needed after date to 45 days for ILL holds, stays 14 days for regular holds. * 'Recalled' and 'Overdue' checkouts (#601) * Adds 'Awaiting Recalled Processing' transaction status to checkouts query. This displays as 'Recalled'. Removes duplicate query from holds query. Adds logic the displays for checkouts that displays 'Overdue' if we are past the due date. Test for all of this. * Recalled items display 'Recalled, Please Return ASAP' * Capitalize the 'M' in 'E-Mail' to get holds query to work properly (#604) * Check if user barred, if so flash error and redirect to summaries (#602) * Refactored 'See all holds' text into translation ymls. Changed the ill results 'See all __' button to say 'See all holds'. (#606) * Link to new non-ill hold from new ill hold form (#610) * Adds text for directing to regular hold screen. Also text. * Test for non-ill link * Add ILLiad materials to summary counts (#605) * Fixes ILL hold. With Ruby 3 upgrade, positional vs keyword arguments were separated. This caused some errors with the SymphonyClientParser that were resolved. * adds ILLiad materials to summary counts * adds specs for summary counts including ILLiad materials * refactored summary controller to create new ILLiad response class. fixed specs that were failing from new ILL summary logic --------- Co-authored-by: whereismyjetpack <djb44@psu.edu> Co-authored-by: Alex Kiessling <32677188+ajkiessl@users.noreply.github.com> Co-authored-by: Sarah Smulligan <64047083+Smullz622@users.noreply.github.com> Co-authored-by: Banu Kutlu <bzk60@psu.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored 'See all holds' text into translation ymls. Changed the ill results 'See all __' button to say 'See all holds'.
I couldn't get this page to load locally to double check that this works. The tests pass, though.
Closes #595