psu-libraries · whereismyjetpack · Sep 29, 2022 · Sep 13, 2022 · Sep 13, 2022
diff --git a/app/components/patron_field_component.html.erb b/app/components/patron_field_component.html.erb
diff --git a/app/components/patron_field_component.rb b/app/components/patron_field_component.rb
diff --git a/app/controllers/patrons_controller.rb b/app/controllers/patrons_controller.rb
diff --git a/app/helpers/patron_helper.rb b/app/helpers/patron_helper.rb
diff --git a/app/models/patron.rb b/app/models/patron.rb
@@ -110,27 +110,6 @@ def library
     fields.dig('library', 'key')
   end
 
-  def email
-    extract_address_data('EMAIL')
-  end
-
-  def state
-    address[:city_state]&.chomp&.last 2
-  end
-
-  def city
-    address[:city_state]&.split(',')&.first
-  end
-
-  def address
-    {
-      street1: extract_address_data('STREET1'),
-      street2: extract_address_data('STREET2'),
-      city_state: extract_address_data('CITY/STATE'),
-      zip: extract_address_data('ZIP')
-    }
-  end
-
   def custom_information
     fields['customInformation']
   end
@@ -155,14 +134,6 @@ def fields
       record['fields']
     end
 
-    def address_fields
-      fields['address1']
-    end
-
-    def extract_address_data(address_field)
-      address_fields.find { |a| a&.dig('fields', 'code', 'key') == address_field }&.dig('fields', 'data') || nil
-    end
-
     def standing_code
       fields.dig('standing', 'key')
     end

diff --git a/app/models/patron_argument_error.rb b/app/models/patron_argument_error.rb
diff --git a/app/services/symphony_client.rb b/app/services/symphony_client.rb
@@ -14,7 +14,6 @@ class SymphonyClient
 
   DELAY = 0.75
   MAX_WAIT_TIME = 30
-  SAFE_PATRON_ADDRESS_FIELDS = [:email, :street1, :street2, :zip].freeze
 
   def login(user_id, password)
     response = request('/user/staff/login', method: :post, json: {
@@ -127,27 +126,6 @@ def place_hold(patron, session_token, item_barcode, hold_args)
                           json: body
   end
 
-  def update_patron_info(patron:, params:, session_token:)
-    body = {
-      "resource": '/user/patron',
-      "key": patron.key,
-      "fields": {
-        "lastName": params[:last_name],
-        "middleName": params[:middle_name],
-        "firstName": params[:first_name],
-        "suffix": params[:suffix],
-        "address1": patron_address(params)
-      }
-    }
-
-    authenticated_request "/user/patron/key/#{patron.key}",
-                          headers: {
-                            'x-sirs-sessionToken': session_token
-                          },
-                          method: :put,
-                          json: body
-  end
-
   # Accepts the Libraries' lending policy/opts the user into wage garnishment.
   # Changes the patron's standing from BARRED to OK and sets the garnish date to today's date.
   def accept_lending_policy(patron:, session_token:)
@@ -257,29 +235,6 @@ def get_patron_record(remote_user, session_token)
 
   private
 
-    def patron_address(params)
-      params.permit(SAFE_PATRON_ADDRESS_FIELDS)
-        .to_h
-        .transform_keys(&:camelize)
-        .transform_keys(&:upcase)
-        .map { |field, value| patron_address_1_template field: field, value: value }
-        .push patron_address_1_template field: 'CITY/STATE', value: "#{params[:city]}, #{params[:state]}"
-    end
-
-    def patron_address_1_template(field:, value:)
-      {
-        "resource": '/user/patron/address1',
-        "fields":
-              {
-                "code": {
-                  "resource": '/policy/patronAddress1',
-                  "key": field
-                },
-                "data": value
-              }
-      }
-    end
-
     def time_left_to_request_again?(start)
       return true if DateTime.now < (start + MAX_WAIT_TIME.seconds)
 

diff --git a/app/views/content/_user_util_links.html.erb b/app/views/content/_user_util_links.html.erb
@@ -1,6 +1,7 @@
 <div class="row">
   <div class="col-md-12">
     <ul class="card-body">
+        <li><%= link_to t('user_util_links.update_address'), 'https://accounts.psu.edu' %></li>
         <li><%= link_to t('user_util_links.feedback'), 'https://libraries.psu.edu/website-feedback' %></li>
         <li><%= link_to t('user_util_links.questions'), 'https://libraries.psu.edu/services/borrow-renew' %></li>
         <li><%= link_to t('user_util_links.borrowing'), 'https://libraries.psu.edu/services/borrow-renew/borrowing-privileges' %></li>

diff --git a/app/views/layouts/_navigation.html.erb b/app/views/layouts/_navigation.html.erb
@@ -9,9 +9,6 @@
         <%= render partial: 'shared/nav_link', locals: { name: 'Checkouts/Renewals', path: checkouts_path } %>
         <%= render partial: 'shared/nav_link', locals: { name: 'Holds', path: holds_path } %>
         <%= render partial: 'shared/nav_link', locals: { name: 'Bills', path: fines_path } %>
-        <% if patron&.valid? %>
-          <%= render partial: 'shared/nav_link', locals: { name: 'Update Address', path: patron_path(patron) } %>
-        <% end %>
       </ul>
     </div>
   </div>

diff --git a/app/views/patrons/edit.html.erb b/app/views/patrons/edit.html.erb
diff --git a/app/views/patrons/show.html.erb b/app/views/patrons/show.html.erb
diff --git a/config/locales/en.yml b/config/locales/en.yml
@@ -31,6 +31,7 @@
 
 en:
   user_util_links:
+    update_address: 'Update your address and other information at accounts.psu.edu'
     borrowing: 'Borrowing privileges: information about loan periods, check out limits, and more'
     questions: 'Frequently asked questions: borrowing and renewing'
     user_privacy: 'Information about library user privacy'

diff --git a/config/routes.rb b/config/routes.rb
@@ -12,7 +12,6 @@
   resources :summaries, :fines, :checkouts, only: [:index]
   resources :holds, only: [:index, :new, :create]
   resources :redis_jobs, only: [:show, :destroy]
-  resources :patrons, only: [:show, :edit, :update]
 
   patch '/holds/batch', to: 'holds#batch_update', as: :holds_batch_update
   delete '/holds/batch', to: 'holds#batch_destroy', as: :holds_batch_destroy