Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make spinner smaller #261

Merged
merged 4 commits into from
Sep 18, 2020
Merged

make spinner smaller #261

merged 4 commits into from
Sep 18, 2020

Conversation

banukutlu
Copy link
Contributor

@banukutlu banukutlu commented Sep 16, 2020 •
edited
Loading

also show only one spinner per checkout for renewals

Note: Need to get Ruth's feedback on this change.

@banukutlu banukutlu requested a review from cdmo September 16, 2020 18:58
@banukutlu banukutlu self-assigned this Sep 16, 2020
cdmo
cdmo suggested changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@cdmo cdmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment in line with code

@cdmo cdmo merged commit a8f2632 into master Sep 18, 2020
@cdmo cdmo deleted the spinner-change branch September 18, 2020 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdmo cdmo cdmo approved these changes

Assignees

@banukutlu banukutlu

Labels
None yet
Projects
None yet
Milestone
0.3.x Theming and Final Prep
Development

Successfully merging this pull request may close these issues.
2 participants
@banukutlu @cdmo