Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forces renew session actions to go through same auth pipeline as a br… #250

Merged
merged 1 commit into from
Sep 10, 2020

Conversation

cdmo
Copy link
Contributor

@cdmo cdmo commented Sep 10, 2020

…and new user (to the application)

I did force a renew by making renew_session_token run and it did redirect properly. In master it does not. Basically I forced it to run by assigning the unless to a var, adding a binding.pry and then running the renew unless that var. Then I just tampered with the var by setting it to false when I wanted it to renew.

      x = symphony_client.ping?(current_user)
      binding.pry
      renew_session_token unless x

@cdmo cdmo added this to the 0.3.x Theming and Final Prep milestone Sep 10, 2020
@cdmo cdmo self-assigned this Sep 10, 2020
@cdmo cdmo requested a review from banukutlu September 10, 2020 02:50
Copy link
Contributor

@banukutlu banukutlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to be working 👍 thanks

@banukutlu banukutlu merged commit af9cd18 into master Sep 10, 2020
@banukutlu banukutlu deleted the 236-redir-auth branch September 10, 2020 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants