Skip to content

Commit

Permalink
Fixes smushing in smaller screens (#308)
Browse files Browse the repository at this point in the history
* Fixes smushing in smaller screens
* Removes asterisk from Email address field
  • Loading branch information
cdmo authored Oct 28, 2020
1 parent ec2a305 commit 2b2dcc6
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions app/components/patron_field_component.html.erb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<div class="row m-2">
<p>
<div class="col-2 text-right"><strong><%= label %>:</strong></div>
<div class="col"><%= value %></div>
<div class="col-sm-4 col-md-3 col-lg-2 text-sm-right"><strong><%= label %>:</strong></div>
<div class="col"><%= value %></div>
</p>
</div>
2 changes: 1 addition & 1 deletion app/views/patrons/edit.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
</div>

<div class="form-group row">
<%= label_tag :email, '*Email Address:', class: 'col-sm-2 col-form-label' %>
<%= label_tag :email, 'Email Address:', class: 'col-sm-2 col-form-label' %>
<div class="col-sm-10 col-lg-5">
<%= email_field_tag 'email', @patron.email, class: 'form-control' %>
<small class="form-text text-muted">
Expand Down
2 changes: 1 addition & 1 deletion spec/views/patrons/edit.html.erb_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
render
expect(rendered).to match(/\*First Name/)
expect(rendered).to match(/\*Last Name/)
expect(rendered).to match(/\*Email Address/)
expect(rendered).to match(/Email Address/)
expect(rendered).to match(/\*Street/)
expect(rendered).to match(/\*City/)
expect(rendered).to match(/\*State/)
Expand Down

0 comments on commit 2b2dcc6

Please sign in to comment.