Skip to content

Commit

Permalink
Merge branch 'main' into return_annotation_brackets
Browse files Browse the repository at this point in the history
  • Loading branch information
jpy-git authored Apr 6, 2022
2 parents fc48804 + 9b30740 commit 20649d1
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 14 deletions.
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ repos:
- types-PyYAML
- tomli >= 0.2.6, < 2.0.0
- types-typed-ast >= 1.4.1
- click >= 8.0.0
- click >= 8.1.0
- platformdirs >= 2.1.0

- repo: https://github.com/pre-commit/mirrors-prettier
Expand Down
3 changes: 2 additions & 1 deletion docs/faq.md
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,8 @@ _Black_ is timid about formatting Jupyter Notebooks. Cells containing any of the
following will not be formatted:

- automagics (e.g. `pip install black`)
- non-Python cell magics (e.g. `%%writeline`)
- non-Python cell magics (e.g. `%%writeline`). These can be added with the flag
`--python-cell-magics`, e.g. `black --python-cell-magics writeline hello.ipynb`.
- multiline magics, e.g.:

```python
Expand Down
13 changes: 5 additions & 8 deletions gallery/gallery.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,9 @@
from concurrent.futures import ThreadPoolExecutor
from functools import lru_cache, partial
from pathlib import Path
from typing import ( # type: ignore # typing can't see Literal
from typing import (
Generator,
List,
Literal,
NamedTuple,
Optional,
Tuple,
Expand All @@ -24,12 +23,11 @@

PYPI_INSTANCE = "https://pypi.org/pypi"
PYPI_TOP_PACKAGES = (
"https://hugovk.github.io/top-pypi-packages/top-pypi-packages-{days}-days.json"
"https://hugovk.github.io/top-pypi-packages/top-pypi-packages-30-days.min.json"
)
INTERNAL_BLACK_REPO = f"{tempfile.gettempdir()}/__black"

ArchiveKind = Union[tarfile.TarFile, zipfile.ZipFile]
Days = Union[Literal[30], Literal[365]]

subprocess.run = partial(subprocess.run, check=True) # type: ignore
# https://github.com/python/mypy/issues/1484
Expand Down Expand Up @@ -64,8 +62,8 @@ def get_pypi_download_url(package: str, version: Optional[str]) -> str:
return cast(str, source["url"])


def get_top_packages(days: Days) -> List[str]:
with urlopen(PYPI_TOP_PACKAGES.format(days=days)) as page:
def get_top_packages() -> List[str]:
with urlopen(PYPI_TOP_PACKAGES) as page:
result = json.load(page)

return [package["project"] for package in result["rows"]]
Expand Down Expand Up @@ -128,13 +126,12 @@ def get_package(

def download_and_extract_top_packages(
directory: Path,
days: Days = 365,
workers: int = 8,
limit: slice = DEFAULT_SLICE,
) -> Generator[Path, None, None]:
with ThreadPoolExecutor(max_workers=workers) as executor:
bound_downloader = partial(get_package, version=None, directory=directory)
for package in executor.map(bound_downloader, get_top_packages(days)[limit]):
for package in executor.map(bound_downloader, get_top_packages()[limit]):
if package is not None:
yield package

Expand Down
10 changes: 6 additions & 4 deletions tests/test_black.py
Original file line number Diff line number Diff line change
Expand Up @@ -1256,23 +1256,25 @@ def test_assert_equivalent_different_asts(self) -> None:

def test_shhh_click(self) -> None:
try:
from click import _unicodefun
from click import _unicodefun # type: ignore
except ImportError:
self.skipTest("Incompatible Click version")
if not hasattr(_unicodefun, "_verify_python3_env"):

if not hasattr(_unicodefun, "_verify_python_env"):
self.skipTest("Incompatible Click version")

# First, let's see if Click is crashing with a preferred ASCII charset.
with patch("locale.getpreferredencoding") as gpe:
gpe.return_value = "ASCII"
with self.assertRaises(RuntimeError):
_unicodefun._verify_python3_env() # type: ignore
_unicodefun._verify_python_env()
# Now, let's silence Click...
black.patch_click()
# ...and confirm it's silent.
with patch("locale.getpreferredencoding") as gpe:
gpe.return_value = "ASCII"
try:
_unicodefun._verify_python3_env() # type: ignore
_unicodefun._verify_python_env()
except RuntimeError as re:
self.fail(f"`patch_click()` failed, exception still raised: {re}")

Expand Down

0 comments on commit 20649d1

Please sign in to comment.