Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move deposit request nil check for all #14849

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Move deposit request nil check for all #14849

merged 1 commit into from
Jan 30, 2025

Conversation

terencechain
Copy link
Member

Deposit request nil check was only applied under requestsStartIndex == params.BeaconConfig().UnsetDepositRequestsStartIndex, but it should be applied under all conditions. Moving it outside the if condition

@terencechain terencechain requested a review from a team as a code owner January 30, 2025 20:18
@terencechain terencechain added this pull request to the merge queue Jan 30, 2025
Merged via the queue into develop with commit 89967fe Jan 30, 2025
16 checks passed
@terencechain terencechain deleted the deposit-req-nil-check branch January 30, 2025 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james-prysm james-prysm james-prysm approved these changes

@saolyn saolyn Awaiting requested review from saolyn saolyn is a code owner automatically assigned from prysmaticlabs/core-team

@rkapka rkapka Awaiting requested review from rkapka rkapka is a code owner automatically assigned from prysmaticlabs/core-team

@dB2510 dB2510 Awaiting requested review from dB2510 dB2510 is a code owner automatically assigned from prysmaticlabs/core-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@terencechain @james-prysm