Handle AttesterSlashingElectra everywhere in the codebase
#14823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalepae
reviewed
Jan 27, 2025
| @@ -395,3 +395,149 @@ func TestProcessAttesterSlashings_AppliesCorrectStatusCapella(t *testing.T) { | |||
| require.Equal(t, uint64(31000000000), newState.Balances()[1]) | |||
| require.Equal(t, uint64(32000000000), newState.Balances()[2]) | |||
| } | |||
|
|
|||
| func TestProcessAttesterSlashings_AppliesCorrectStatusDeneb(t *testing.T) { | |||
There was a problem hiding this comment.
There is a lot of copy pasted code with equivalent functions from other forks.
Could this be factorized?
rkapka
force-pushed
the
eip-7549-slasher-pt2
branch
from
c83b17f to
1dceaa8
Compare
nalepae
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
Updates several pieces of the codebase for Electra slashing support:
transition.go, where the maximum number of slashings in a block was always the Phase0 config valueAcknowledgements