Change Max Payload Size #14692
Merged
Change Max Payload Size #14692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
previously approved these changes
Dec 6, 2024
terencechain
reviewed
Dec 6, 2024
beacon-chain/p2p/encoder/ssz.go
Outdated
| @@ -16,8 +16,9 @@ import ( | |||
| var _ NetworkEncoding = (*SszNetworkEncoder)(nil) | |||
|
|
|||
| // MaxGossipSize allowed for gossip messages. | |||
| var MaxGossipSize = params.BeaconConfig().GossipMaxSize // 10 Mib. | |||
| var MaxChunkSize = params.BeaconConfig().MaxChunkSize // 10 Mib. | |||
| var MaxGossipSize = params.BeaconConfig().GossipMaxSize // 10 Mib. | |||
There was a problem hiding this comment.
MaxGossipSize is no longer used
prestonvanloon
approved these changes
Dec 9, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature Improvement
What does this PR do? Why is it needed?
This PR changes the max payload size by using a new variable to represent the uncompressed payload size so that the correct value is checked against when decoding payloads.
Which issues(s) does this PR fix?
N.A
Other notes for review
Acknowledgements