missed adding electra process epoch on state replay - devnet 1 #14272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-prysm
commented
Jul 30, 2024
| } | ||
| } else if err != nil { | ||
| return nil, err | ||
| } | ||
| defer func() { | ||
| SkipSlotCache.MarkNotInProgress(key) | ||
| }() | ||
|
|
||
| for state.Slot() < slot { | ||
| customErrFn := func(ctx context.Context, st state.BeaconState) error { |
There was a problem hiding this comment.
reviewer please carefully look at the use of this function and let me know if this works well for our usecase
potuz
reviewed
Jul 30, 2024
potuz
reviewed
Jul 30, 2024
potuz
reviewed
Jul 30, 2024
| func ProcessEpoch(ctx context.Context, state state.BeaconState) (state.BeaconState, error) { | ||
| var err error | ||
| if time.CanProcessEpoch(state) { | ||
| if state.Version() == version.Phase0 { |
There was a problem hiding this comment.
can we switch the order of these ones?
potuz
reviewed
Jul 30, 2024
Comment on lines
+264
to
+265
| if fn != nil { | ||
| if err = fn(ctx, state); err != nil { |
There was a problem hiding this comment.
Suggested change
| if fn != nil { | |
| if err = fn(ctx, state); err != nil { | |
| if fn != nil && (err = fn(ctx, state)) != nil { |
james-prysm
commented
Jul 30, 2024
| @@ -231,42 +222,63 @@ func ProcessSlots(ctx context.Context, state state.BeaconState, slot primitives. | |||
| defer func() { | |||
| SkipSlotCache.MarkNotInProgress(key) | |||
| }() | |||
| state, err = ProcessSlotsCore(ctx, span, state, slot, cacheBestBeaconStateOnErrFn(highestSlot, key)) | |||
There was a problem hiding this comment.
please look at the use of cacheBestBeaconStateOnErrFn carefully
potuz
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
The core logic of process slots was duplicated in the replay function,so we forgot to update epoch processing in the replay function for the electra process slot. This PR refactors the core logic to be reusable and adds the corrected electra process epoch
Which issues(s) does this PR fix?
Fixes #
Other notes for review