-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fuzz ssz round trip #14006
Merged
Merged
Fuzz ssz round trip #14006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ering unknown fields therein.
b35201c
to
52ac22f
Compare
52ac22f
to
52f987d
Compare
Please run |
saolyn
approved these changes
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
prestonvanloon
approved these changes
May 21, 2024
fredriksvantes
added a commit
to fredriksvantes/documentation-1
that referenced
this pull request
Jul 3, 2024
**Name**: Bhargava Shastry **Project**: Ethereum Foundation **Team**: Protocol Security (EF) **Joined**: 01/01/2023 **Link to relevant work**: [https://github.com/bshastry](https://github.com/bshastry) **Summary of their work/eligibility**: Bhargava has been working full time in the EF since January 2019. He was working full-time as a security engineer for the Solidity team full-time until the end of 2023. In January 2023, he moved to the Protocol security team while still supporting Solidity. For the past six months he has been working full time to secure the Protocol by writing fuzzers and auditing the network layer. His current focus is the consensus later clients. Some of his contributions include * private fuzzers for go-libp2p, go-multistream, go-multiformat, rust-libp2p, ethereum_ssz * Prysm (prysmaticlabs/prysm#14006), * public fuzzers for the Solidity compiler (https://github.com/ethereum/solidity/pulls?q=is%3Apr+author%3Abshastry+is%3Aclosed) * Issues reported in Solidity compiler (https://github.com/ethereum/solidity/issues/created_by/bshastry) Bhargava will have done his 6 months of full time protocol work on the 1st of August.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other (adds fuzzer)
What does this PR do? Why is it needed?
This PR adds a new fuzzer for testing ssz roundtrip coding. It is needed to increase test coverage.
Which issues(s) does this PR fix?
None
Other notes for review
Incorporates earlier feedback from private PR.