Command-line interface for visualizing min/max span bucket #13748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v4lproik
changed the title
|
does not emphasise the fact we are working on the slasher DB. |
nalepae
requested changes
Mar 18, 2024
|
Something strange: gives me: While (just the epoch changes) gives me: I would expect that if the This might be an issue in the visualization tool, or more likely this might be the root cause of #13658. |
|
Thank you for the review, I have implemented your feedbacks. Regarding your question about the values from the previous chunk when querying a previous epoch for a minspan, it is directly correlated to the issue #13658 as you pointed out. You can see my output when running the Latest current Epoch the BN processed is:
As you can see, the 'round robin' really happens here as the epoch prior to and next to the requested epoch are getting updated which doesn't happen with the current implementation due to the bug pointed out in #13749 |
|
Thanks for the updates! Last comment: The visualizer should either:
The same limitation applies for future epochs ( |
|
Yes, I agree. Having defined lower and upper bounds for an epoch range is indeed preferable. It's quite difficult to get the first epoch attested for a validator index as the slasher only stores the latest epoch. Thus, given these constraints, admitting that the lower bound is always equal to Let me know if you have any ideas for a straightforward solution that wouldn't require storing new data in the database to obtain that information. |
v4lproik
force-pushed
the
feat-add-slasher-visu-cli
branch
from
c604046 to
206ff0c
Compare
nalepae
requested changes
Mar 20, 2024
Yes totally. However, when running: I get: So the stored epochs in the DB are: `[34844:38940] `` However, running the same command with I guess data for epochs |
|
That's fair enough. My train of thought was focused on obtaining both the lower and upper bounds of the entire chunk, despite the round-robin nature of the 2D chunking, which may present incorrect values for those epochs. Since having a differently sized chunk would be somewhat unconventional, displaying an empty cell or an invalid marker, such as "-", makes sense. I have implemented it. Let me know wyt. |
nisdas
reviewed
Mar 20, 2024
nalepae
approved these changes
Mar 27, 2024
Merged
via the queue into
prysmaticlabs:develop
with commit Mar 27, 2024
acc307b
16 of 17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
This tool is a straightforward command-line interface for visualizing buckets, helping in understanding 2D chunking, exploring the contents of the span bucket, and facilitating the detection of potential bugs in the slasher.
Which issues(s) does this PR fix?
#13658
Other notes for review
Let me know if you'd rather not add an external dependency, I'll just add a simple table display function then.
Output
Here is an example of the cli: