Optimize SubmitAggregateSelectionProof VC action
#13711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
force-pushed
the
optimize-SubmitAggregateSelectionProof
branch
from
ba6ac41 to
eef89b3
Compare
saolyn
reviewed
Mar 11, 2024
# Conflicts: # validator/client/beacon-api/beacon_api_validator_client.go # validator/client/grpc-api/grpc_validator_client.go
saolyn
reviewed
Mar 19, 2024
| ) | ||
|
|
||
| func (c *beaconApiValidatorClient) submitAggregateSelectionProof(ctx context.Context, in *ethpb.AggregateSelectionRequest) (*ethpb.AggregateSelectionResponse, error) { | ||
| func (c *beaconApiValidatorClient) submitAggregateSelectionProof( |
There was a problem hiding this comment.
Just had a look at deep source, seems there is somewhere where these are both pointer and recover, might be worth another look
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
There is no need to make some requests to the beacon node inside
SubmitAggregateSelectionProofwhen we already have the data available in the duty. We just need to pass this extra data to the function.This reduces the whole action from a few hundred ms to a few ms.