Add the Ability for Prysm To Handle Trusted Peers #12492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
reviewed
Jun 12, 2023
beacon-chain/p2p/discovery.go
Outdated
| for _, a := range addrs { | ||
| info, err := peer.AddrInfoFromP2pAddr(a) | ||
| if err != nil { | ||
| log.WithError(err).Error("Could not derive peer info from multiaddress") |
There was a problem hiding this comment.
You may want to add a.String() in the log to know which address failed
| // Set trusted peers for those that are provided as static addresses. | ||
| pids := peerIdsFromMultiAddrs(addrs) | ||
| s.peers.SetTrustedPeers(pids) | ||
| peersToWatch = append(peersToWatch, s.cfg.StaticPeers...) |
There was a problem hiding this comment.
Why don't we currently watch static peers?
There was a problem hiding this comment.
it was a bug, which is why its being fixed here
rkapka
approved these changes
Jun 12, 2023
james-prysm
approved these changes
Jun 12, 2023
terencechain
pushed a commit
that referenced
this pull request
Jun 12, 2023
* add all changes * add to peers to watch * add tests * Update beacon-chain/p2p/peers/peerdata/store_test.go * radek's review --------- Co-authored-by: Radosław Kapka <rkapka@wp.pl> Co-authored-by: james-prysm <90280386+james-prysm@users.noreply.github.com>
terencechain
pushed a commit
that referenced
this pull request
Jun 12, 2023
* add all changes * add to peers to watch * add tests * Update beacon-chain/p2p/peers/peerdata/store_test.go * radek's review --------- Co-authored-by: Radosław Kapka <rkapka@wp.pl> Co-authored-by: james-prysm <90280386+james-prysm@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
banned or disconnected due to our pruning routines/peer scorer.
Which issues(s) does this PR fix?
N.A
Other notes for review