Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logs for build block times #12452

Merged
merged 3 commits into from
May 24, 2023
Merged

Add logs for build block times #12452

merged 3 commits into from
May 24, 2023

Conversation

terencechain
Copy link
Member

This PR added two proposer RPC logs and modified one proposer RPC log

  • It adds an info log to signal the start of block construction. Good signal for node operators to know when the beacon node started building block. (similar to geth's begin building payload). sinceSlotStartTime is the time diff between now and slot start time.
  • It adds an info log to signal the end of the block construction. Good signal for node operators to know when the beacon node has completed the building block. (similar to geth's stopped building payload). sinceSlotStartTime is the time diff between now and slot start time.
  • It added more fields to Received header with bid to signal slot, validator index, and time difference since start.

More thoughts

  • Should them be debug? I thought info is appropriate given proposing is a rare event
  • Anymore missing fields?
  • Interop mode might become a bit noisy

@terencechain terencechain requested a review from a team as a code owner May 23, 2023 17:00
@terencechain terencechain self-assigned this May 23, 2023
@prylabs-bulldozer prylabs-bulldozer bot merged commit f4d3939 into develop May 24, 2023
@prylabs-bulldozer prylabs-bulldozer bot deleted the build-block-logs branch May 24, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants