Add aggregation metrics #12417
Merged
Add aggregation metrics #12417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -39,7 +39,11 @@ func (s *Service) prepareForkChoiceAtts() { | |||
| if err := s.batchForkChoiceAtts(s.ctx); err != nil { | |||
| log.WithError(err).Error("Could not prepare attestations for fork choice") | |||
| } | |||
| log.WithField("latency", time.Since(t).Milliseconds()).Debug("batched forkchoice attestations") | |||
| if slots.TimeIntoSlot(s.genesisTime) < intervals[1] { | |||
There was a problem hiding this comment.
panic if intervals is length 0. Probably better to do a length check
There was a problem hiding this comment.
Preston had the same comment, but interval is a hardcoded configuration flag, this can never be 0
There was a problem hiding this comment.
solved by converting to array
Comment on lines
+256
to
+260
| // TimeIntoSlot returns the time duration elapsed between the current time and | ||
| // the start of the current slot | ||
| func TimeIntoSlot(genesisTime uint64) time.Duration { | ||
| return time.Since(StartTime(genesisTime, CurrentSlot(genesisTime))) | ||
| } |
There was a problem hiding this comment.
Very useful helper! Can replace this on many things that we do
terencechain
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the logs when batching attestations for forkchoice and adds metrics for the first two intervals in the slot where we aggregate.