Add Pubsub Metrics Tracer #12178
Merged
Add Pubsub Metrics Tracer #12178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beacon-chain/p2p/monitoring.go
Outdated
Comment on lines
74
to
78
| pubsubTopicsGraft = promauto.NewGaugeVec(prometheus.GaugeOpts{ | ||
| Name: "p2p_pubsub_graft_count", | ||
| Help: "The number of graft messages sent for a particular topic", | ||
| }, | ||
| []string{"topic"}) |
There was a problem hiding this comment.
Should this be p2p_pubsub_graft_total?
Should this be a counter (only increases) instead of a gauge?
There was a problem hiding this comment.
Same feedback for all of these metrics
prestonvanloon
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
Adds in a new raw tracer whose main purpose is to record metrics from messages broadcasted and received by our gossipsub router.
Which issues(s) does this PR fix?
N.A
Other notes for review