lock forkchoice on calls to Ancestor #12162
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lock forkchoice on calls to
Ancestor()
.Fixes #12161
The function
Ancestor()
currently exposed in forkchoice is only accessed when processing attestations currently from the sync package. The single entry point is the functionancestor
from the blockchain package. It would be safe to lock within forkchoice. However, as discussed on slack, we are moving to a system in whichchain-info.go
that expose forkchoice with the appropriate locks.This PR does the minimal amount of work to fix #12161 while adhering to the above design: we lock on a blockchain method (which is now exposed and moved to the
chain-info.go
file) and set a new interface within it with this exposed method.In future PRs we should move methods that are simple wrappers to forkchoice, from different interfaces, to this interface and do not expose
Forkchoicer()
which gives access to all of forkchoice to other packages. This is a larger project that will require time.