Keep pry-stack-explorer available with Ruby 3.0 #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fursich
commented
Dec 31, 2020
| @@ -5,6 +5,10 @@ | |||
| require file | |||
| end | |||
|
|
|||
| if RUBY_VERSION >= '2.7.2' | |||
| # NOTE: https://bugs.ruby-lang.org/issues/17000 | |||
| Warning[:deprecated] = true | |||
There was a problem hiding this comment.
To keep warnings displayed in CI environment, we could either
- setting environment var:
RUBYOPTS='-W:deprecated', - or turn on
Warning[:deprecated]at runtime
I had to choose the latter as the earlier approach is not accepted by Ruby < 2.7.2 (Ruby aborts as it is not a recognizable option).
This is necessary only after Ruby 2.7.2.
| @@ -20,7 +20,7 @@ Gem::Specification.new do |s| | |||
|
|
|||
| s.specification_version = 4 | |||
|
|
|||
| s.add_runtime_dependency 'binding_of_caller', '~> 0.7' | |||
| s.add_runtime_dependency 'binding_of_caller', '~> 1.0' | |||
There was a problem hiding this comment.
After upgrading binding._of_caller, I confirmed all the test passed green, at least at my end
|
Looks good to me, thanks! |
|
@joallard Thanks for your swift action! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
Thanks a lot for maintaining this useful gem.
I happened to notice bundle install fails with this gem when I upgrade an application to Ruby3.
Looks like the dependent gem binding_of_caller has to be updated to 1.0.0 (the relevant PR can be found here)
Also as Ruby 2.7 no longer emits deprecation warnings by default, I placed an explicit setting to turn that on in test environment.
Please advise if there's something I'm missing. I'm happy to work on it if any.
Hope that helps!