Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enum names before items #430

Closed
wants to merge 1 commit into from

Conversation

victorgomes
Copy link

@victorgomes
Copy link
Author

@leonm1 PTAL!

Signed-off-by: Victor Gomes <victorgomes@chromium.org>
@martijneken
Copy link
Contributor

martijneken commented Mar 5, 2025

Does this not require updating the v8 version?

maybe(
git_repository,
name = "v8",
# 10.7.193.13
commit = "6c8b357a84847a479cd329478522feefc1c3195a",
remote = "https://chromium.googlesource.com/v8/v8",
shallow_since = "1664374400 +0000",
patches = [
"@proxy_wasm_cpp_host//bazel/external:v8.patch",
"@proxy_wasm_cpp_host//bazel/external:v8_include.patch",
],
patch_args = ["-p1"],
)

@mpwarres was working on that here: #409

@victorgomes
Copy link
Author

This initial change doesn't require a V8 update. I was planning further work ... However, the current V8 version is approximately three years old. Updating V8 would significantly impact this PR, and the required effort is too large. Therefore, I'm abandoning this PR and will instead patch via copybara in g3.

@victorgomes victorgomes closed this Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants