Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding /-/healthy and /-/ready endpoints #153

Merged
merged 3 commits into from
Dec 11, 2019
Merged

Adding /-/healthy and /-/ready endpoints #153

merged 3 commits into from
Dec 11, 2019

Conversation

timkra
Copy link
Contributor

@timkra timkra commented Dec 7, 2019

Endpoint that indicates if the Consul Exporter is healthy.

Should close #150

@simonpasquier
Copy link
Member

Thanks for the pull request. To be consistent with Prometheus and Alertmanager, can you change the URL to /-/healthy and simply return OK? And for completeness, you can also implement the /-/ready endpoint which would do the same.

Timo Krause added 3 commits December 9, 2019 13:01

Verified

This commit was signed with the committer’s verified signature.
shockey kyle shockey
Endpoint that indicates if the Consul Exporter is healthy.

Signed-off-by: Timo Krause <tkrause@saba.com>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
To be more consitent with Prometheus and Alertmanager.

Signed-off-by: Timo Krause <tkrause@saba.com>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Readiness endpoint to return OK when Consul Exporter is ready to retrive request.

Signed-off-by: Timo Krause <tkrause@saba.com>
@timkra timkra changed the title Adding a /health endpoint Adding /-/healthy and /-/ready endpoint Dec 9, 2019
@simonpasquier simonpasquier changed the title Adding /-/healthy and /-/ready endpoint Adding /-/healthy and /-/ready endpoints Dec 11, 2019
Copy link
Member

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@simonpasquier simonpasquier merged commit 4a89ed6 into prometheus:master Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add /health endpoint returning 200 OK
2 participants