Make HTTPMetricHandler class public #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernd
force-pushed
the
improve/expose-http-metric-handler
branch
from
6cd6f34 to
8ad06f2
Compare
|
Looks good. Could you rebase it to the |
bernd
force-pushed
the
improve/expose-http-metric-handler
branch
from
8ad06f2 to
80c479c
Compare
This makes the HTTPMetricHandler reusable to allow custom HTTPServer implementations. Fixes prometheus#529 Signed-off-by: Bernd Ahlers <bernd@graylog.com>
bernd
force-pushed
the
improve/expose-http-metric-handler
branch
from
80c479c to
8426c8c
Compare
@fstab I rebased the PR to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the HTTPMetricHandler reusable to allow custom HTTPServer implementations.
Fixes #529
@fstab @tomwilkie This is a replacement PR for the closed #530. The #529 issue has been closed already but having this class exposed would help me with a custom
HTTPServerimplementation. 😄 Thank you!