Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle slashes in pgw grouping label values. #491

Merged
merged 1 commit into from
Jul 29, 2019
Merged

Conversation

brian-brazil
Copy link
Contributor

Good base64 support was only added in Java 8,
we support back to Java 6 so this is a little unclean.

@beorn7

@brian-brazil
Copy link
Contributor Author

Fixes #159

Copy link
Member

@beorn7 beorn7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Java… 🤦‍♂️

Perhaps add a comment in the code to explain why it is done in the weird way?

Good base64 support was only added in Java 8,
we support back to Java 6 so this is a little unclean.

Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
@brian-brazil
Copy link
Contributor Author

Done

@brian-brazil brian-brazil merged commit e28b835 into master Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants