Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow an HttpServer to be passed in #471

Merged
merged 1 commit into from
Apr 24, 2019
Merged

Allow an HttpServer to be passed in #471

merged 1 commit into from
Apr 24, 2019

Conversation

thecoop
Copy link
Contributor

@thecoop thecoop commented Apr 8, 2019

@brian-brazil PR for #470 - allowing a HttpServer to be passed in, so HttpsServer could be used instead

@brian-brazil
Copy link
Contributor

Can you add the DCO?

@thecoop
Allow a specific HttpServer to be specified, so HttpsServer could be …
9d6368d 
…used (#470)

Signed-off-by: Simon Cooper <thecoop@runbox.com>
@thecoop
Copy link
Contributor Author

thecoop commented Apr 24, 2019

Done!

@brian-brazil brian-brazil merged commit 4e0e752 into prometheus:master Apr 24, 2019
@brian-brazil
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thecoop @brian-brazil