Fix prometheus URL in prometheus-adapter #1463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That check is running successfully on my laptop, how can I trigger another CI run? |
andrein
force-pushed
the
prometheus-adapter
branch
from
291738a to
53e0a47
Compare
paulfantom
reviewed
Oct 25, 2021
| @@ -33,7 +33,7 @@ spec: | |||
| - --config=/etc/adapter/config.yaml | |||
| - --logtostderr=true | |||
| - --metrics-relist-interval=1m | |||
| - --prometheus-url=http://prometheus-k8s.monitoring.svc.cluster.local:9090/ | |||
| - --prometheus-url=http://prometheus-k8s.monitoring:9090/ | |||
There was a problem hiding this comment.
Does this actually work without svc in url? I would expect http://prometheus-k8s.monitoring.svc:9090/ to work correctly, but I am not sure about http://prometheus-k8s.monitoring:9090/
There was a problem hiding this comment.
Yes, it does. The kubelet sets the following in the pods resolv.conf
nameserver 10.32.0.10
search <namespace>.svc.cluster.local svc.cluster.local cluster.local
options ndots:5
https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/#namespaces-of-services
There was a problem hiding this comment.
http://prometheus-k8s.monitoring.svc:9090/ also works, I can update the PR if you want it that way.
andrein
force-pushed
the
prometheus-adapter
branch
from
53e0a47 to
a6442df
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the kube-prometheus stack on a cluster with a cluster domain that is different than the default
.cluster.local,prometheus adapter fails to connect to the prometheus server with the following error:
This would also fail if prometheus was deployed in a different namespace than the namespace specified in
$.values.common.namespaceType of change
CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Changelog entry