Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated policy/v1beta1 kubernetes api #1433

Merged

Conversation

markusheinemann
Copy link
Contributor

@markusheinemann markusheinemann commented Oct 12, 2021

Resolves #1427

Description

Since Kubernetes version 1.21 the policy/v1beta1 api is replaced with policy/v1 and will be removed with version 1.25. This PR migrates related Kubernetes resources to the newer version.

policy/v1 is only available in kubernetes version 1.21+.

Type of change

What type of changes does your code introduce to the kube-prometheus? Put an x in the box that apply.

  • CHANGE (fix or feature that would cause existing functionality to not work as expected)
  • FEATURE (non-breaking change which adds functionality)
  • BUGFIX (non-breaking change which fixes an issue)
  • ENHANCEMENT (non-breaking change which improves existing functionality)
  • NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Changelog entry

Please put a one-line changelog entry below. Later this will be copied to the changelog file.

remove deprecated policy/v1beta1 kubernetes api

Copy link
Member

@paulfantom paulfantom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

This makes kube-prometheus incompatible with k8s < 1.21 but we are not supporting that version either way.

@dgrisonnet dgrisonnet merged commit 2b2af2b into prometheus-operator:main Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PodDisruptionBudget is deprecated
4 participants