Use pcntl_async_signals for php >=7.1 #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes agree, I leave this ticket open for a short while, because this requires a minor version bump. I want to have all PR's merged before I put this in and tag a new release. Thanks for your contribution. |
prolic
approved these changes
Jan 26, 2020
|
Can you rebase this? Tests are failing. |
I’ll do it tonight |
genhoi
force-pushed
the
pcntl_async_signals
branch
from
5e06adc to
d99588f
Compare
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suggest raising the minimum version of php to 7.1 and use pcntl_async_signals for best perfomance