Handle symlinks in nodes_path or classes_path as separate entities
#26
+41
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simu
force-pushed
the
fix/discover-nodes-classes-symlink
branch
from
9cd2808 to
b5f63c1
Compare
We introduce function `to_lexical_absolute()` which converts a Path into its normalized absolute form without resolving symlinks. We replace our usage of `canonicalize()` with that function, so that we correctly treat symlinks in `nodes_path` or `classes_path` as separate entities (nodes or classes). Additionally, we also use `to_lexical_absolute()` when generating the `uri` in the `NodeInfoMeta` struct in `Node::parse()` to match Python reclass's behavior.
simu
force-pushed
the
fix/discover-nodes-classes-symlink
branch
from
b5f63c1 to
15d1c22
Compare
bastjan
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduce function
to_lexical_absolute()which converts a Path into its normalized absolute form without resolving symlinks. We replace our usage ofcanonicalize()with that function, so that we correctly treat symlinks innodes_pathorclasses_pathas separate entities (nodes or classes).Checklist
bug,enhancement,documentation,change,breaking,dependency,internalas they show up in the changelog