Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only remove node status when the node is unavailable #516

Merged
merged 2 commits into from
Dec 20, 2021

Conversation

DuodenumL
Copy link
Contributor

场景:一个node被设置了bypass,但是我们只希望它不参与后续的部署,node上面的workloads还可以正常提供服务。

问题:agent启动后更新了node status,selfmon收到了变更信息,调用SetNode,打算把这个node设置成UP。但是因为它被bypass了,所以触发了n.IsDown(),node status又被删除。selfmon再次收到变更信息,然后调用SetNode把node设置为DOWN,并且将上面所有workload标记为not running。

修复:修改一下判断条件,只有在非bypass且down的情况才会删除node status。

@DuodenumL DuodenumL changed the title fix: keep the node status when a running node is bypassed fix: only remove node status when the node is unavailable Dec 17, 2021
@DuodenumL DuodenumL force-pushed the hotfix/bypass branch 2 times, most recently from b1d9043 to a39d2d0 Compare December 20, 2021 08:46
@CMGS CMGS merged commit e160ade into projecteru2:master Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants