Fix issue of too many logs due to raw bytes #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jschwinger233
commented
Oct 28, 2021
•
jschwinger233
commented
- CreateWorkload 里的用户请求用 compact 模式, 打印在一行
- LinuxFile 和 RawArgs 这两个 bytes 字段, 实现了 String() 和 LitterDump() 方法, 避免输出 raw bytes, 只输出长度和其他信息
jschwinger233
force-pushed
the
zc/fix-litter
branch
from
954c5ea to
e0ded33
Compare
jschwinger233
changed the title
DuodenumL
reviewed
Oct 28, 2021
types/options.go
Outdated
|
|
||
| // LitterDump fro litter.Dumper | ||
| func (r RawArgs) LitterDump(w io.Writer) { | ||
| w.Write([]byte(string(r))) // nolint:errcheck // here can't import core/log due to cycle dependence |
jschwinger233
changed the title
jschwinger233
force-pushed
the
zc/fix-litter
branch
from
e0ded33 to
2b68aaa
Compare
jschwinger233
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.