[SPVR-80] create workload metadata before starting workload #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
目前还在测试中。 可能存在的问题：回滚的时候如果删除metadata失败了，是否仍要删除这个workload？（现在的做法是仍要删除） |
DuodenumL
force-pushed
the
feature/meta
branch
from
4ab94c3 to
1a8fe58
Compare
DuodenumL
changed the title
DuodenumL
changed the title
DuodenumL
force-pushed
the
feature/meta
branch
from
1a8fe58 to
5cebcad
Compare
|
删除 metadata 失败不重要吧, 本来也有 dissociate 这种, 其实是最终一致性的... |
DuodenumL
force-pushed
the
feature/meta
branch
from
5cebcad to
8108306
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
之前部署workload时，流程是：1. 启动workload 2. 将workload的metadata存储至ETCD中。
在这两步之间，存在一小段时间，这个workload已经启动，但是ETCD里还没有相关的数据。如果这段时间agent来上报workload状态，就会报错。
这个PR更改了部署workload的流程，变成：1. 写入metadata 2. 启动workload 3. 检查metadata是否需要变更，如果需要的话则update。