fix race condition when TTL=0 #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonicmuroq
force-pushed
the
fix-this-race
branch
from
855ded6 to
af39271
Compare
tonicmuroq
force-pushed
the
fix-this-race
branch
from
af39271 to
3ed0e79
Compare
|
覆盖率下降了 |
|
我不管, 我本地跑还有挂了的测试呢 |
|
同样的 case, 代码行数拆多了当然下降了, 不要 care |
|
加 case |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
有这么一种 race: 在 core 创建容器的时候, 还没有把容器保存下来呢, agent 那边进程起来了, detect 到了, 开始报 status 了.
考虑到以上, 觉得 TTL 为 0 的时候不需要去检测有没有 entity, 没有就没有吧... 多大点事... 毕竟这个事情不能在 agent 这改, agent 是尝试多少次好呢, 多少次都不行... 顺便, 有没有可能 cachecloud 拿个 IP 要半天就是因为这个, 那个集群里 120s 才能报一次呢, 如果第一次写失败, 下一次需要等两分钟...