New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return error for txn condition not succeeded #441

Merged

CMGS merged 1 commit into projecteru2:master from jschwinger233:zc/etcd

Jun 24, 2021

Member

jschwinger233 commented Jun 24, 2021 •

edited

Loading

比如对 BatchUpdate 来说, 我们的 txn 是:

if 所有 key 都存在, 且不等于新 value
则 put
否则 get

所以对于业务调用方, 比如 UpdateWorkloads, 成功更新 workloads meta 和事务条件的成功与否强相关, 所以这个 pr 对 txn response.Succeed 做了判断.

jschwinger233 force-pushed the zc/etcd branch from 2d86b37 to 4778182 Compare

June 24, 2021 06:15

Member Author

jschwinger233 commented Jun 24, 2021

store.meta 里有五个方法返回了 TxnResponse, 其中只有 BatchUpdate / BatchCreate / Update 有这个问题


          return error for txn condition not succeeded

311208c

jschwinger233 force-pushed the zc/etcd branch from 4778182 to 311208c Compare

June 24, 2021 06:30

jschwinger233 changed the title ~~[WIP] Return error for txn condition not succeeded~~ Return error for txn condition not succeeded

CMGS merged commit 02fb1bf into projecteru2:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet