Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix copy from workloads #422

Merged
merged 1 commit into from
Jun 2, 2021
Merged

fix copy from workloads #422

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions rpc/rpc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,6 +442,7 @@ func (v *Vibranium) Copy(opts *pb.CopyOptions, stream pb.CoreRPC_CopyServer) err

var bs []byte
tw := tar.NewWriter(w)
defer tw.Close()
if bs, err = ioutil.ReadAll(m.Data); err != nil {
log.Errorf(ctx, "[Copy] Error during extracting copy data: %v", err)
return
Expand Down Expand Up @@ -470,9 +471,11 @@ func (v *Vibranium) Copy(opts *pb.CopyOptions, stream pb.CoreRPC_CopyServer) err
}
break
}
msg.Data = p[:n]
if err = stream.Send(msg); err != nil {
v.logUnsentMessages(ctx, "Copy", err, m)
if n > 0 {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if we need to send message only when n>0

Copy link
Contributor Author

@tonicmuroq tonicmuroq Jun 2, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when client uses this, an empty []byte{} is meaningless

msg.Data = p[:n]
if err = stream.Send(msg); err != nil {
v.logUnsentMessages(ctx, "Copy", err, m)
}
}
}
}
Expand Down