bugfix: make correction of total available calculation #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bug 是这样的, 之前的 total 是每个 scheduler 轮流计算之后取最小值, 但是由于资源是正交的, 这种算法会有问题. 比如, cpu scheduler 算出来 total=1, plan={node1: 1}; volume scheduler 算出来 total=1, plan={node2: 1}, 之前的算法算下来 total=1, 然后实际的 total 应该是 0, 因为 node1 的 volume cap = 0, node2 的 cpu cap = 0. 因此也需要 Dispense 的时候做 capacity 校验, 之前由于有 total 所以认为不需要判断, 现在需要了. |
jschwinger233
changed the title
jschwinger233
changed the title
jschwinger233
changed the title
|
增加一个单测覆盖这个场景吧 |
好 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.