improve fill & each strategy #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jschwinger233
commented
Jan 12, 2021
jschwinger233
commented
- cap-based priority
- make clear limit semantic
- delete resourceType in xxxPlan arguments
jschwinger233
force-pushed
the
zc/strategy
branch
2 times, most recently
from
2a91eea to
e57f864
Compare
CMGS
reviewed
Jan 14, 2021
CMGS
reviewed
Jan 14, 2021
| scheduleInfosLength := len(infos) | ||
| if limit == 0 { |
There was a problem hiding this comment.
这里还有一点问题, limit = 0 之前的语义是:
- avg: 注释里写的是“容量够的尽量填, 不够就算了”,
- fill: 注释里没解释, 但是从处理细节来看, limit=0 就是不做第二轮筛选(第一轮是把已满足 count > need 的筛掉), 所以也可以理解为 “尽量填”
然而由于 avg / fill 都是一进去就 if scheduleInfosLength < limit { return err } , 所以其实之前是没有实现注释里的语义的...
然后我觉得“尽量填”这个需求似乎没有“全部填”常用?
因为“尽量填”可能导致编排下来的结果是所有节点 cap 都不够, 所以一个都不填了, 似乎用户不会有这种期望..
所以我改成了 “全部填” 的语义了...
然后实现上还有一点小问题, 我再改改, 加两个测试..
jschwinger233
force-pushed
the
zc/strategy
branch
2 times, most recently
from
da86ea1 to
b8e718e
Compare
jschwinger233
force-pushed
the
zc/strategy
branch
from
b8e718e to
a769297
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.