Forward-port improvements to the facet suggest feature #3511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to @cbeer and @maxkadel for identifying these issues while backporting this feature to release-8.x! * Provide the option to opt out of this feature (in 8.x, it is opt-in). You can add suggest: false to your facet config in the catalog controller if you don't want to use it for a particular field. * Use text_field_tag * Correct typo in debounce.js * Run i18n-tasks translate-missing, rather than add-missing. This pulls preliminary translations from the Google Cloud Translate API. * Remove redundant assignment * Remove unnecessary assignment Co-authored-by: Chris Beer <chris@cbeer.info> Co-authored-by: Max Kadel <mkadel@princeton.edu>
sandbergja
force-pushed
the
forward-port-facet-suggest-improvements
branch
from
390c13b to
98d3827
Compare
jcoyne
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While backporting #3367, @cbeer and @maxkadel identified some issues, which were addressed before merging it to release-8x. This PR "forward-ports" those corrections, so that main and 9.x also can benefit from them.
Thanks to @cbeer and @maxkadel for identifying these issues while backporting this feature to release-8.x!
suggest: falseto your facet config in the catalog controller if you don't want to use it for a particular field.text_field_tagi18n-tasks translate-missing, rather thanadd-missing. This pulls preliminary translations from the Google Cloud Translate API.