Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hover style from non-controllable element #3470

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

jcoyne
Copy link
Member

@jcoyne jcoyne commented Dec 13, 2024

The hover style indicates to the user that the currently hovered element is a clickable control. However in this case it is not a control, so removing the hover style improves UX.

Fixes #3469

The hover style indicates to the user that the currently hovered element is a clickable control. However in this case it is not a control, so removing the hover style improves UX.
Copy link
Contributor

@seanaery seanaery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great -- thanks for tackling it! I noticed this happening a while back and also found it to be an undesirable effect, but just never got around to filing an issue.

@seanaery seanaery merged commit ea66b44 into main Dec 13, 2024
13 checks passed
@seanaery seanaery deleted the remove-hover-color branch December 13, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hover style applied to constraint values make it appear like a link/button, but there is no action.
2 participants