CMakeLists.txt: Remove -mthumb-interwork

[kraj]

This option is meaningless with aapcs ABI
which is the default for Linux and android
for armv7+ architectures

As an aside it helps in compiling with clang
where this option is absent

Signed-off-by: Khem Raj raj.khem@gmail.com

[joesavage]

Looks good to me. The baseline architectural target for Ne10 is ARMv7, and devices supporting this shouldn't really be using obsolete calling conventions intended for the older, ARMv4-era architectures that this flag seems to be catered for (in recent versions of GCC, at least). Certainly, the default ABI used for ARMv7+ compilation is AAPCS, as you outlined.

The situation for older versions of GCC may be a different story, as this flag may have played a different role, but this shouldn't be an issue for us when targeting ARMv7 and above (as there are no special interworking exceptions to the EABI in this case, as indicated in section 5.6 of ARM IHI 0042F). As such, I'm in agreement that this flag is totally useless — on ARMv7+, -mthumb-interwork appears to be purely for non-AAPCS ABIs as the AAPCS EABI handles Thumb interworking just fine on its own.

Have you filled out a CLA to allow me to merge this contribution? (see contributing.md)

[kraj]

@joesavage CLA ? no, and its too much work for such a small patch

[joesavage]

FWIW, I agree. For now, though, this project is still in the process of removing the CLA, so I don't believe I'm allowed to merge this yet. Maybe an exception can be made for such a tiny change, I'm not sure, but we can always wait until the CLA has been removed (which will hopefully be soon) — it's not like this change is especially urgent.

[kraj]

I am fine either way.

[miniupnp]

@joesavage CLA has been dropped, right ?