feat(ldap): hot reloading ldap credentials on change #2167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurentiuNiculae
requested review from
eusebiu-constantin-petu-dbk,
rchincha and
andaaron
as code owners
laurentiuNiculae
force-pushed
the
hotreload-ldap
branch
6 times, most recently
from
ea4c668 to
0aeeb19
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2167 +/- ##
==========================================
- Coverage 92.34% 92.24% -0.10%
==========================================
Files 165 165
Lines 28493 28525 +32
==========================================
+ Hits 26311 26313 +2
- Misses 1611 1635 +24
- Partials 571 577 +6 ☔ View full report in Codecov by Sentry. |
laurentiuNiculae
force-pushed
the
hotreload-ldap
branch
2 times, most recently
from
9d24f6b to
59713b0
Compare
rchincha
reviewed
Jan 19, 2024
laurentiuNiculae
force-pushed
the
hotreload-ldap
branch
from
59713b0 to
e0f679d
Compare
Signed-off-by: Laurentiu Niculae <niculae.laurentiu1@gmail.com>
laurentiuNiculae
force-pushed
the
hotreload-ldap
branch
from
e0f679d to
af7b97e
Compare
andaaron
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue does this PR fix:
Closes #2161
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.