PICS documentation - moved from SDK #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview deployed at https://d2doqw88td69eq.cloudfront.net/pr-39 |
|
Preview deployed at https://d2doqw88td69eq.cloudfront.net/pr-39 |
|
I will do an editorial review of this |
Vyrastas
suggested changes
Mar 3, 2025
Comment on lines
+32
to
+33
| | ANC.S.C00.Rsp | Device accepts ANC command 0x00 on the ANC server cluster | | ||
| | ANC.S.C01.Rsp | Device accepts ANC command 0x00 on the ANC server cluster | |
There was a problem hiding this comment.
These 2 are the same description?
Comment on lines
+37
to
+38
| | ANC.C.F00 | Device ANC client is capable of understanding the feature with bit 0 | | ||
| | ANC.C.F01 | Device ANC client is capable of understanding the feature with bit 0 | |
|
|
||
| Additionally, there are node-level PICS, which appear as a part of the MCORE | ||
| PICS set. These PICS codes describe node level support such as the radio, | ||
| whether the device is commissionable, whether the device comes with a QR code |
There was a problem hiding this comment.
Suggested change
| whether the device is commissionable, whether the device comes with a QR code | |
| whether the device is commissionable, whether the device comes with a QR code, |
| to manually set all the PICS codes for a device. The PICS XML files and the PICS | ||
| tool are distributed as part of the official specification release package and | ||
| are available on | ||
| [Causeway](https://groups.csa-iot.org/wg/members-all/document/folder/2269). |
There was a problem hiding this comment.
Since this is a public document, do we want to be clear that this requires a CSA member login?
| present for the endpoint being described. Documentation on how to use the PICS | ||
| tool can be found in the PICS tool readme in the tool menu. | ||
|
|
||
| Some of of the full-node MCORE elements really only apply to the root node, |
There was a problem hiding this comment.
Suggested change
| Some of of the full-node MCORE elements really only apply to the root node, | |
| Some of the full-node MCORE elements really only apply to the root node, |
Comment on lines
+114
to
+117
| are exposed directly on the device. For example, cluster presence is determined | ||
| from the server list on an endpoint, feature maps, attribute and command lists | ||
| correspond directly to the PICS.S.Fxx, PICS.S.Axxxx and PICS.S.Cxx.Xx PICS | ||
| codes. The Matter SDK provides a tool to pre-fill these values in the PICS XML |
There was a problem hiding this comment.
Suggested change
| are exposed directly on the device. For example, cluster presence is determined | |
| from the server list on an endpoint, feature maps, attribute and command lists | |
| correspond directly to the PICS.S.Fxx, PICS.S.Axxxx and PICS.S.Cxx.Xx PICS | |
| codes. The Matter SDK provides a tool to pre-fill these values in the PICS XML | |
| are exposed directly on the device. For example, cluster presence is determined | |
| from the server list on an endpoint. Feature maps and attribute and command lists | |
| correspond directly to the PICS.S.Fxx, PICS.S.Axxxx and PICS.S.Cxx.Xx PICS | |
| codes. The Matter SDK provides a tool to pre-fill these values in the PICS XML |
| - MCORE (base.xml) PICS | ||
| - Manual or other non-element PICS | ||
| - PICS describing whether optionally-writable attributes are writable | ||
| - any other non-element PICS |
There was a problem hiding this comment.
Suggested change
| - any other non-element PICS | |
| - Any other non-element PICS |
| PICS files should validate properly. This will also generate the list of test | ||
| cases. | ||
|
|
||
| Note that the TH will also guide test selection by pre-selecting the required |
There was a problem hiding this comment.
I assume TH = Test Harness, can we use TH (Test Harness)?
Comment on lines
+184
to
+201
| Placeholder for more information coming in a subsequent PR. Needs to cover | ||
|
|
||
| - formatting (link out to test plans doc) | ||
| - requirement to have all the elements listed | ||
| - how to do conformance in a way the PICS tool can handle - (note - special | ||
| attention to choice conformance, otherwise conformance) | ||
| - why you shouldn't use PICS values in tests other than at the top level | ||
|
|
||
| ## Using PICS in test scripts | ||
|
|
||
| Placeholder for more information coming in a subsequent PR. Needs to cover | ||
| top-level and step-wise pics in yaml and python and also where they should NOT | ||
| be used. | ||
|
|
||
| ## CI PICS format | ||
|
|
||
| Placeholder for information about the CI PICS format, CI-only PICS and the | ||
| gotchas there. |
There was a problem hiding this comment.
We should leave placeholders out of published docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.