-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDK Rework and matter.js addition #31
Conversation
As discussed in PMTT and iterated on https://docs.google.com/document/d/1uqVFVWaNr31nHHlmarKzuIOLKsmSOjZoSoWJbwFLueQ/edit?usp=sharing here is the PR to bring the new content for the SDK - Development page to life.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the record, this isn't a drive-by rubber-stamp, I reviewed the original doc and provided comments there. Comments were all addressed in the doc and that is reflected here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit, LGTM otherwise
Added Matter Fast Track Recertification FAQ
Fixed indentations in MatterFastTrackRecertificationFAQ
As discussed in PMTT and iterated on https://docs.google.com/document/d/1uqVFVWaNr31nHHlmarKzuIOLKsmSOjZoSoWJbwFLueQ/edit?usp=sharing here is the PR to bring the new content for the SDK - Development page to life.
I tried to resolve conflicts and had a bit fun with my fork ... so now also commits from merging in main are included here :-( I can recreate the PR if needed, else "Squash&Merge" should work fine too |
@Apollon77 I believe the indexes for the new "Development" section will need some adjustments since the "Certification" section is there? |
Let me recreate the pr tomorrow to get it solved and also remove the merge fun. |
Preview deployed at https://d1teub3jrrfss6.cloudfront.net/pr-31 |
As discussed in PMTT and iterated on https://docs.google.com/document/d/1uqVFVWaNr31nHHlmarKzuIOLKsmSOjZoSoWJbwFLueQ/edit?usp=sharing here is the PR to bring the new content for the SDK - Development page to life.