Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK Rework and matter.js addition #31

Closed
wants to merge 11 commits into from

Conversation

Apollon77
Copy link
Contributor

As discussed in PMTT and iterated on https://docs.google.com/document/d/1uqVFVWaNr31nHHlmarKzuIOLKsmSOjZoSoWJbwFLueQ/edit?usp=sharing here is the PR to bring the new content for the SDK - Development page to life.

As discussed in PMTT and iterated on https://docs.google.com/document/d/1uqVFVWaNr31nHHlmarKzuIOLKsmSOjZoSoWJbwFLueQ/edit?usp=sharing here is the PR to bring the new content for the SDK - Development page to life.
Copy link
Contributor

@cecille cecille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record, this isn't a drive-by rubber-stamp, I reviewed the original doc and provided comments there. Comments were all addressed in the doc and that is reflected here.

Copy link
Contributor

@Vyrastas Vyrastas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, LGTM otherwise

@Apollon77
Copy link
Contributor Author

I tried to resolve conflicts and had a bit fun with my fork ... so now also commits from merging in main are included here :-( I can recreate the PR if needed, else "Squash&Merge" should work fine too

@jcps07
Copy link
Contributor

jcps07 commented Jan 15, 2025

@Apollon77 I believe the indexes for the new "Development" section will need some adjustments since the "Certification" section is there?

@Apollon77
Copy link
Contributor Author

Let me recreate the pr tomorrow to get it solved and also remove the merge fun.

@Apollon77
Copy link
Contributor Author

@jcps07 see #34 ... it is an exact recreation of this PR but without all these merge conflicts and on current main

@jcps07 jcps07 closed this in #34 Jan 16, 2025
Copy link

Preview deployed at https://d1teub3jrrfss6.cloudfront.net/pr-31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants