-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce RAM Usage for EFR32MG21 examples #7431
Conversation
Reduce OT CLI buffers size Increase lighting app to 13k like it was already done for Lock app fix zcl callback prototype, that wasn't overwriting the weak one
#define MEMP_SEPARATE_POOLS (1) | ||
#define LWIP_PBUF_FROM_CUSTOM_POOLS (0) | ||
#define MEMP_USE_CUSTOM_POOLS (0) | ||
#define PBUF_POOL_SIZE (6) | ||
#define PBUF_POOL_SIZE (5) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems pretty small to me, but maybe it's ok.... Need to support at least incoming message, outgoing message, retransmit buffer, standalone ack. That's for a single message exchange. And assuming that nothing else uses pbufs.
I suspect @tcarmelveilleux has thoughts on this.
Reduce OT CLI buffers size Increase lighting app to 13k like it was already done for Lock app fix zcl callback prototype, that wasn't overwriting the weak one
Reduce OT CLI buffers size Increase lighting app to 13k like it was already done for Lock app fix zcl callback prototype, that wasn't overwriting the weak one
Reduce OT CLI buffers size Increase lighting app to 13k like it was already done for Lock app fix zcl callback prototype, that wasn't overwriting the weak one
Problem
Change overview
Freed up ~4k of RAM
Increase lighting app to 13k, like it was already done for Lock app, to prevent some CSR failures due to lack of free heap space.
Fix
emberAfPostAttributeChangeCallback
definition in lock_app, size argument didn't receive the type change and wasn't overwriting the WEAK declarationTesting
Manual testing on EFR32MG21 wiht both Lighting and Lock example.
Both now compile
Validate the examples are still working using python controller :
Fixes #7336